Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify: flaky TestLargeIdentifyMessage #1523

Closed
marten-seemann opened this issue May 24, 2022 · 3 comments · Fixed by #1555 or #1984
Closed

identify: flaky TestLargeIdentifyMessage #1523

marten-seemann opened this issue May 24, 2022 · 3 comments · Fixed by #1555 or #1984
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor

  === RUN   TestLargeIdentifyMessage
      id_test.go:845: test peer1 has peer2 addrs correctly
      id_test.go:860: test peer2 has peer1 addrs correctly
      id_test.go:873: testing addrs just after disconnect
      id_test.go:876: 
          	Error Trace:	id_test.go:41
          	            				id_test.go:876
          	Error:      	elements differ
          	            	
          	            	extra elements in list A:
          	            	([]interface {}) (len=2) {
          	            	 (*multiaddr.multiaddr)({
          	            	  bytes: ([]uint8) (len=8) {
          	            	   00000000  04 7f 00 00 01 06 c3 e4                           |........|
          	            	  }
          	            	 }),
          	            	 (*multiaddr.multiaddr)({
          	            	  bytes: ([]uint8) (len=11) {
          	            	   00000000  04 7f 00 00 01 91 02 ed  e9 cc 03                 |...........|
          	            	  }
          	            	 })
          	            	}
          	            	
          	            	
          	            	listA:
          	            	([]multiaddr.Multiaddr) (len=2) {
          	            	 (*multiaddr.multiaddr)({
          	            	  bytes: ([]uint8) (len=8) {
          	            	   00000000  04 7f 00 00 01 06 c3 e4                           |........|
          	            	  }
          	            	 }),
          	            	 (*multiaddr.multiaddr)({
          	            	  bytes: ([]uint8) (len=11) {
          	            	   00000000  04 7f 00 00 01 91 02 ed  e9 cc 03                 |...........|
          	            	  }
          	            	 })
          	            	}
          	            	
          	            	
          	            	listB:
          	            	([]multiaddr.Multiaddr) {
          	            	}
          	Test:       	TestLargeIdentifyMessage
          	Messages:   	QmTYuoLmQHu34jyaN9ywjFA7r1bQLaapYZTddoRupT1ENg did not have addr for QmQ81pQuehk4dRkwkDGRrqpvQ4Ga6hZqzTkydGE3S1KkWG
      id_test.go:877: peerstore has no signed record for peer QmQ81pQuehk4dRkwkDGRrqpvQ4Ga6hZqzTkydGE3S1KkWG
  --- FAIL: TestLargeIdentifyMessage (9.11s)
@marten-seemann
Copy link
Contributor Author

@MarcoPolo MarcoPolo linked a pull request Jun 1, 2022 that will close this issue
@MarcoPolo
Copy link
Collaborator

Re openeing since I think there are some fixes still left to do

@schomatis
Copy link

Picking this up as related to (or maybe duplicate of) #1164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
3 participants