Nightly build broken: Invalid Mode Parameter for Liblouis > 3.7

[reiner-dolp]

Since 4 days ago (commit liblouis/liblouis#08084a6 ), passing 0 as mode parameter to lou_translateString gives:

Invalid mode parameter: 0

According to the docs

The mode parameter specifies how the translation should be done. The valid values of mode are
defined in liblouis.h. They are all powers of 2, so that a combined mode can be specified by adding
up different values.

The docs seem wrong, since the _lou_isValidMode is expecting exactly one enum variant to be set:

const int validTranslationModes[] = { noContractions, compbrlAtCursor, dotsIO,
	compbrlLeftCursor, ucBrl, noUndefinedDots, partialTrans };
int
_lou_isValidMode(int mode) {
	for (int i = 0; i < (sizeof(validTranslationModes) / sizeof(*validTranslationModes));
			i++) {
		if (validTranslationModes[i] == mode) {
			return 1;
		}
	}
	return 0;
}

@egli So, am I completely misunderstanding what this code is supposed to do or should _lou_isValidMode be rewritten to accept a bitwise combination of translation modes? Has 0 always been an invalid value?

[egli]

@reiner-dolp sorry about that. I thought I was clever. I pushed a fix for the worst problem to master. Now the mode can be 0 again. However I guess also bitwise combinations should be allowed. I don't see how this could be achieved with my code atm.
CC @bertfrees

[bertfrees]

Oh I didn't think about that either.

What about the following?

int isValidMode(int mode) {
    for (int i = 0; i < (sizeof(validTranslationModes) / sizeof(*validTranslationModes)); i++)
        mode &= ~validTranslationModes[i];
    return !mode;
}

By the way shouldn't validTranslationModes be defined static?

[egli]

Thanks @bertfrees for that code.

By the way shouldn't validTranslationModes be defined static?

What is the effect of that?

[egli]

Fixed in liblouis/liblouis@c0820bc (hopefully)

[bertfrees]

Because now it is extern?

[egli]

Ok, should be static now