Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_passthroughfs sometimes fails due to timestamp difference #57

Open
ThomasWaldmann opened this issue Jun 10, 2022 · 5 comments
Open
Milestone

Comments

@ThomasWaldmann
Copy link
Collaborator

ThomasWaldmann commented Jun 10, 2022

Seen on github actions CI:

Traceback (most recent call last):
  File "/home/runner/work/pyfuse3/pyfuse3/test/test_examples.py", line 124, in test_passthroughfs
    tst_passthrough(src_dir, mnt_dir)
  File "/home/runner/work/pyfuse3/pyfuse3/test/test_examples.py", line 412, in tst_passthrough
    assert_same_stats(src_name, mnt_name)
  File "/home/runner/work/pyfuse3/pyfuse3/test/test_examples.py", line 438, in assert_same_stats
    assert  v1 == v2, 'Attribute {} differs by {} ({} vs {})'.format(
AssertionError: Attribute st_mtime_ns differs by 4000074 (1654852943987067641 vs 1654852943983067567)
assert 1654852943987067641 == 1654852943983067567
@ThomasWaldmann
Copy link
Collaborator Author

ThomasWaldmann commented Sep 28, 2022

Still happens 2023-07, just have seen this with github CI.

@ThomasWaldmann
Copy link
Collaborator Author

______________________________ test_passthroughfs ______________________________
Traceback (most recent call last):
   File "/home/runner/work/pyfuse3/pyfuse3/test/test_examples.py", line 124, in test_passthroughfs
    tst_passthrough(src_dir, mnt_dir)
  File "/home/runner/work/pyfuse3/pyfuse3/test/test_examples.py", line 414, in tst_passthrough
    assert_same_stats(src_name, mnt_name)
  File "/home/runner/work/pyfuse3/pyfuse3/test/test_examples.py", line 440, in assert_same_stats
    assert  v1 == v2, 'Attribute {} differs by {} ({} vs {})'.format(
AssertionError: Attribute st_mtime_ns differs by 3999985 (1691339543559117222 vs 1691339543555117237)
assert 1691339543559117222 == 1691339543555117237

@ThomasWaldmann ThomasWaldmann added this to the 3.3.1 milestone Aug 7, 2023
@ThomasWaldmann
Copy link
Collaborator Author

@Nikratio I am wondering: is this just a cosmetic issue due to timestamp granularity of different filesystems? 4ms seems a bit much for that. Or is it a bug? What do you think?

@Nikratio
Copy link
Contributor

Nikratio commented May 7, 2024

I'm not sure what's going on here. FUSE uses ns-granularity to report the timestamp from the underlying filesystem, so there should be no loss of accuracy.

@Nikratio
Copy link
Contributor

Nikratio commented May 7, 2024

To debug this, I'd add a sleep prior to the comparison and see if that makes the difference go up.

@ThomasWaldmann ThomasWaldmann modified the milestones: 3.3.1, 3.4.0 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants