Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Donate button is not internationalized when JavaScript is disabled #572

Open
jorgesumle opened this issue Apr 15, 2017 · 1 comment
Open

Donate button is not internationalized when JavaScript is disabled #572

jorgesumle opened this issue Apr 15, 2017 · 1 comment
Assignees
@Changaco
Labels
i18n internationalization

Comments

@jorgesumle
Copy link
Contributor

The text should be the same when JavaScript is disabled:

captura de pantalla de 2017-04-15 03 06 43
@Changaco
Copy link
Member

Changaco commented Apr 15, 2017 •
edited
Loading

Generating SVGs with dynamic text is tricky, we would need to compute the correct button width for the translated word. (Edit: It's not that hard, we can use the textLength attribute like https://shields.io/ does.) Even then, the translations would get mixed up because of #360.

@Changaco Changaco added the i18n internationalization label Apr 15, 2017
@jorgesumle jorgesumle mentioned this issue Aug 20, 2017
Merged
@Changaco Changaco added the good first issue suitable for new contributors label Aug 27, 2020
@Changaco Changaco self-assigned this Dec 31, 2021
@Changaco Changaco removed the good first issue suitable for new contributors label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Changaco Changaco

Labels
i18n internationalization
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Changaco @jorgesumle