ID-3181 AWS SDK Version 3 + Modernised Build #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! @lucascanavan @promie Thank you for modernising the repo. I'm a bit busy this week. I will review this PR this weekend. |
liamqma
reviewed
Oct 19, 2023
package.json
Outdated
| @@ -1,53 +1,51 @@ | |||
| { | |||
| "name": "beanstalkify", | |||
| "name": "elasticsprout", | |||
There was a problem hiding this comment.
What's the reason to change the name here?
There was a problem hiding this comment.
Apologies @liamqma that was my bad. I was testing this project and forgot to change the name back. I've made a commit to rename it back to what it was.
liamqma
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR presents a comprehensive overhaul of changes aimed at modernising our build and bringing it up to date with current best practices. Specifically, we've achieved the following:
tscfor compiling.Further bolstering our confidence in these changes, we have extensively tested this updated codebase. This includes not only publishing it onto npm but also integrating and utilising it within our primary project. All tests and integrations have yielded expected results, reassuring us of the robustness and reliability of this update.
It's worth noting that these changes represent a significant revamp, enhancing not just the functionality but also the maintainability and readability of our codebase.
Note: There's no rush in merging this pull request. Given the extensive changes, I understand the importance of reviewing it meticulously. Please take your time to go through it thoroughly and feel free to publish only when you're completely satisfied. I'm more than willing to make any necessary adjustments or modifications.