Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test motorCANFilterList on M2 main #397

Open
IshDeshpa opened this issue Jan 1, 2024 · 0 comments
Open

Test motorCANFilterList on M2 main #397

IshDeshpa opened this issue Jan 1, 2024 · 0 comments
Labels
enhancement New feature or request M2

Comments

@IshDeshpa
Copy link
Contributor

Describe the problem this feature will solve
Currently, the motorCANFilterList is disabled on our main testing branch. We want this to be enabled to limit the amount of motorCAN messages we are getting, but we cannot enable this until re-testing at Pickle.

Additionally, there exists an easier to understand implementation of CAN filtering by @tiandahuang that we can steal from BPS and integrate into our BPS_CAN driver. We need to re-test this functionality too.

Describe the proposed solution
Re-enable the motorCANFilterList and test MotorCAN->CarCAN forwarding again with DataAcq (or the CANdapter).
Also, add the updated logic from BPS for CAN filtering and test that as well on both CAN buses. Make sure that critical parts of our behavior like Ignition Sequence or CarCAN forwarding still work (this can be tested with the CANdapter).

Describe possible alternatives
Another possible fix would be to limit sending of MotorCAN messages on the motor controller configuration to just what we want it to send, and this may be something you could do in addition, but I think getting CAN filtering working would be a cooler fix. Objectively neither solution is worse than the other though imo.

@IshDeshpa IshDeshpa added the enhancement New feature or request label Jan 1, 2024
@IshDeshpa IshDeshpa mentioned this issue Jan 1, 2024
13 tasks
@IshDeshpa IshDeshpa added the M2 label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request M2
Projects
Status: No status
Development

No branches or pull requests

1 participant