From 431c86de569aeea554c1e4abd1b1bc4e88a66ba0 Mon Sep 17 00:00:00 2001
From: Andrew Grimberg <agrimberg@linuxfoundation.org>
Date: Thu, 12 Oct 2023 09:14:09 -0700
Subject: [PATCH] Refactor: Add annotations on lftools.api.*

Issue: RELENG-4933
Change-Id: I2dde8fa02f2efac810a1ec874989ec1e94dfdeee
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
---
 lftools/api/client.py     | 48 ++++++++++++++++++++++-----------------
 lftools/api/exceptions.py |  3 ++-
 2 files changed, 29 insertions(+), 22 deletions(-)

diff --git a/lftools/api/client.py b/lftools/api/client.py
index 2bf0442e..612ce4df 100644
--- a/lftools/api/client.py
+++ b/lftools/api/client.py
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: EPL-1.0
 ##############################################################################
-# Copyright (c) 2019 The Linux Foundation and others.
+# Copyright (c) 2019, 2023 The Linux Foundation and others.
 #
 # All rights reserved. This program and the accompanying materials
 # are made available under the terms of the Eclipse Public License v1.0
@@ -8,8 +8,10 @@
 # http://www.eclipse.org/legal/epl-v10.html
 ##############################################################################
 """REST API interface using Requests."""
+from __future__ import annotations
 
 import json
+from typing import Any, Dict, Optional, Tuple
 
 import requests
 
@@ -17,34 +19,36 @@
 class RestApi(object):
     """A generic REST API interface."""
 
-    def __init__(self, **params):
+    def __init__(self, **kwargs: Dict[str, str]) -> None:
         """Initialize the REST API class."""
-        self.params = params
+        self.params: Dict[str, Dict[str, str]] = kwargs
 
-        if params["creds"]:
-            self.creds = params["creds"]
+        if kwargs["creds"]:
+            self.creds: Dict[str, str] = kwargs["creds"]
 
         if "timeout" not in self.params:
-            self.timeout = None
+            self.timeout: Optional[int] = None
 
-        self.endpoint = self.creds["endpoint"]
+        self.endpoint: str = self.creds["endpoint"]
 
         if self.creds["authtype"] == "basic":
-            self.username = self.creds["username"]
-            self.password = self.creds["password"]
-            self.r = requests.Session()
+            self.username: str = self.creds["username"]
+            self.password: str = self.creds["password"]
+            self.r: requests.Session = requests.Session()
             self.r.auth = (self.username, self.password)
             self.r.headers.update({"Content-Type": "application/json; charset=UTF-8", "Accept": "application/json"})
 
         if self.creds["authtype"] == "token":
-            self.token = self.creds["token"]
+            self.token: str = self.creds["token"]
             self.r = requests.Session()
-            self.r.headers.update({"Authorization": "Token {}".format(self.token)})
+            self.r.headers.update({"Authorization": f"Token {self.token}"})
             self.r.headers.update({"Content-Type": "application/json"})
 
-    def _request(self, url, method, data=None, timeout=30):
+    def _request(
+        self, url: str, method: str, data: Optional[Any] = None, timeout: int = 30
+    ) -> requests.Response | Tuple[requests.Response, Optional[Dict[str, Any] | str]]:
         """Execute the request."""
-        resp = self.r.request(method, self.endpoint + url, data=data, timeout=timeout)
+        resp: requests.Response = self.r.request(method, self.endpoint + url, data=data, timeout=timeout)
 
         # Some massaging to make our gerrit python code work
         if resp.status_code == 409:
@@ -53,8 +57,8 @@ def _request(self, url, method, data=None, timeout=30):
         if resp.text:
             try:
                 if "application/json" in resp.headers["Content-Type"]:
-                    remove_xssi_magic = resp.text.replace(")]}'", "")
-                    body = json.loads(remove_xssi_magic)
+                    remove_xssi_magic: str = resp.text.replace(")]}'", "")
+                    body: Optional[Dict[str, Any] | str] = json.loads(remove_xssi_magic)
                 else:
                     body = resp.text
             except ValueError:
@@ -65,22 +69,24 @@ def _request(self, url, method, data=None, timeout=30):
 
         return resp, body
 
-    def get(self, url, **kwargs):
+    def get(self, url: str, **kwargs) -> requests.Response | Tuple[requests.Response, Optional[Dict[str, Any] | str]]:
         """HTTP GET request."""
         return self._request(url, "GET", **kwargs)
 
-    def patch(self, url, **kwargs):
+    def patch(self, url: str, **kwargs) -> requests.Response | Tuple[requests.Response, Optional[Dict[str, Any] | str]]:
         """HTTP PATCH request."""
         return self._request(url, "PATCH", **kwargs)
 
-    def post(self, url, **kwargs):
+    def post(self, url: str, **kwargs) -> requests.Response | Tuple[requests.Response, Optional[Dict[str, Any] | str]]:
         """HTTP POST request."""
         return self._request(url, "POST", **kwargs)
 
-    def put(self, url, **kwargs):
+    def put(self, url: str, **kwargs) -> requests.Response | Tuple[requests.Response, Optional[Dict[str, Any] | str]]:
         """HTTP PUT request."""
         return self._request(url, "PUT", **kwargs)
 
-    def delete(self, url, **kwargs):
+    def delete(
+        self, url: str, **kwargs
+    ) -> requests.Response | Tuple[requests.Response, Optional[Dict[str, Any] | str]]:
         """HTTP DELETE request."""
         return self._request(url, "DELETE", **kwargs)
diff --git a/lftools/api/exceptions.py b/lftools/api/exceptions.py
index cbef4e9a..ad53fffa 100644
--- a/lftools/api/exceptions.py
+++ b/lftools/api/exceptions.py
@@ -8,11 +8,12 @@
 # http://www.eclipse.org/legal/epl-v10.html
 ##############################################################################
 """Exceptions for the API client."""
+from __future__ import annotations
 
 
 class UnsupportedRequestType(Exception):
     """Except on an unknown request."""
 
-    def __str__(self):
+    def __str__(self) -> str:
         """Except unknown return type."""
         return "Unknown request type"