Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to your identity after registration skeleton #860

Closed
fricoben opened this issue Jul 22, 2024 · 1 comment · Fixed by #862
Closed

Go to your identity after registration skeleton #860

fricoben opened this issue Jul 22, 2024 · 1 comment · Fixed by #862
Assignees
Labels
🚨 Small bug Bug that should be fix

Comments

@fricoben
Copy link
Contributor

This video shows the feedback after the registration from the UI is strange when I click on go to your domain. The tx is taking long time so that's the issue that sould be fixed soon by Starknet itself, but our way of showing the loading with skeleton makes me think of a bug so I would prefer to make the skeleton better (not only the PFP loadding but all the part of the card with their associated skeleton too and maybe a message with it).

https://www.loom.com/share/c034501fb976404ea9d9794774b0611b

@fricoben fricoben added the 🚨 Small bug Bug that should be fix label Jul 22, 2024
@Kevils
Copy link
Collaborator

Kevils commented Jul 22, 2024

Regarding the skeleton to be implemented on the identity card, I suggest we:

  • Use a loading skeleton for each element that makes up the card: https://mui.com/material-ui/react-skeleton/
  • Add a "refresh" button to refresh the page and display the identity elements. We can use the structure of the image below as an example, with the card loading with skeletons on the left and a refresh button on the right, along with a title and subtitle to inform the user that if the content does not appear, they can refresh the page.
    Screenshot 2024-07-22 at 10 08 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 Small bug Bug that should be fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants