Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the connection button resolve stark domains and PFPs #24

Open
2 tasks
fricoben opened this issue Nov 15, 2024 · 15 comments · May be fixed by #34
Open
2 tasks

Make the connection button resolve stark domains and PFPs #24

fricoben opened this issue Nov 15, 2024 · 15 comments · May be fixed by #34
Assignees
Labels
Expert issue Good for experienced contributors OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution

Comments

@fricoben
Copy link
Contributor

Description 📹

Our top right-corner button is not showing .stark domains and PFPs. We need to make it so so it looks like so

Capture d’écran 2024-11-15 à 09 55 13

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:

  • Refactor the button component to make it resolve stark domains and PFPs using this button component as model
  • Make it work taking example from in this context
  1. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:
    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@fricoben fricoben added Open for contribution An issue that is available for an Only Dust contribution OD Hack Issue reserved for the OD Hack Expert issue Good for experienced contributors labels Nov 15, 2024
@wheval
Copy link
Contributor

wheval commented Nov 22, 2024

Hello @fricoben, I can get this done.
I have worked on something similar here lfglabs-dev/starknet.quest#939.
Please assign. Thank you.

ETA is 1 day.

@0xdevcollins
Copy link

Could I take a shot at this?

@mimisavage
Copy link

Could I take on this issue?

@petersdt
Copy link

petersdt commented Nov 22, 2024

@fricoben May I be assigned to this?

ETA <= 48hrs

@mayasimi
Copy link

Can I be assigned to this?

@NueloSE
Copy link

NueloSE commented Nov 22, 2024

May I take care of this?

@suhas-sensei
Copy link

Mind if I try this one? I will do the requested changes in 36 hours.

@Jagadeeshftw
Copy link

Hi @fricoben,

I want to take up this issue as I have experience with front-end development and can resolve it efficiently. I’ll ensure the button resolves Stark domains and PFPs as described and will raise a PR within the next 12 hours. Could you please assign this issue to me?

@onlydustapp onlydustapp bot assigned Jagadeeshftw and unassigned Jagadeeshftw Nov 24, 2024
@Supa-mega
Copy link

please 🙏 I’d love to work on this task.

@DanielEmmanuel1
Copy link

I’d like to resolve this.

I can have this delivered in less than 48 hrs and will like to take this issue

@Psalmuel01
Copy link

Can I try solving this issue?

@JoshdfG
Copy link

JoshdfG commented Nov 30, 2024

Can I work on this, please?

@onlydustapp onlydustapp bot assigned JoshdfG and NueloSE and unassigned JoshdfG Dec 1, 2024
@Marchand-Nicolas
Copy link
Collaborator

Hello, everything good @NueloSE ?

@NueloSE
Copy link

NueloSE commented Dec 6, 2024

@Marchand-Nicolas

I have done the required task and added a default profile picture incase there isn't anyone from the user's account but the issue is that the domain is showing the user address instead of the user's domain, i even tried buying a domain still nothing is changing.
Then i tried logging out the domain to see if it is actually getting the user's domain it is showing undefined on the console
i even tried following the reference you gave but still nothing
Do you know or have any idea on what i can do to resolve it or is there something i'm missing 🤔

@Marchand-Nicolas
Copy link
Collaborator

@Marchand-Nicolas

I have done the required task and added a default profile picture incase there isn't anyone from the user's account but the issue is that the domain is showing the user address instead of the user's domain, i even tried buying a domain still nothing is changing. Then i tried logging out the domain to see if it is actually getting the user's domain it is showing undefined on the console i even tried following the reference you gave but still nothing Do you know or have any idea on what i can do to resolve it or is there something i'm missing 🤔

Make sure your env variables are fine, especially:
NEXT_PUBLIC_RPC_URL=https://rpc.starknet.id
and the contracts (here are the addresses: https://www.notion.so/lfg-labs/Deployed-Contracts-ee3370b1d20c45b59bb5157ce7f4e017)

@NueloSE NueloSE linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expert issue Good for experienced contributors OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.