You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// shouldn't be possible; lf_thread_join is only called from main thread
return1;
}
if (thread_return) {
*thread_return=thread_1_return;
}
return0;
}
However, future versions of this chip (i.e. an RP4040) may have more cores. Ideally, lf_thread_create and lf_thread_join should be revised to account for this. The generalization probably won't be perfect (since multicore_launch_core1 doesn't lend itself well to more cores), but should be aimed at a potential future with a 4-core RP4040. Something like the following may be used to abstract away multicore_launch_core1:
// assume this function will exist in some future version of the pico-sdk
void multicore_launch(int core, void (*entry)(void)) {
multicore_launch_core1(entry); // for now, assume core == 1
}
This work on generalization will probably lend itself well to future STM32 support, as many STM32 devices do have more than 2 cores.
The text was updated successfully, but these errors were encountered:
Currently, the rp2040 support assumes that there is one main core and one other core:
reactor-c/low_level_platform/impl/src/lf_rp2040_support.c
Lines 223 to 258 in b58a3a5
However, future versions of this chip (i.e. an RP4040) may have more cores. Ideally,
lf_thread_create
andlf_thread_join
should be revised to account for this. The generalization probably won't be perfect (sincemulticore_launch_core1
doesn't lend itself well to more cores), but should be aimed at a potential future with a 4-core RP4040. Something like the following may be used to abstract awaymulticore_launch_core1
:This work on generalization will probably lend itself well to future STM32 support, as many STM32 devices do have more than 2 cores.
The text was updated successfully, but these errors were encountered: