[12.0-stable] pkg/pillar: make ioBundleError deepcopy-able #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error types very often have private members that cannot be marshalled with `json.Marshal` we fix this by only storing the error type and the error string (err.Error()) as values in uppercase members of our own ioBundleError type log output: ``` json Unmarshal in deepCopy: json: cannot unmarshal object into Go struct field IoBundleError.IoBundleList.Error.Errors of type error ``` introduced by d1e13b8 Signed-off-by: Christoph Ostarek <[email protected]> (cherry picked from commit 9cc6ca8)
OhmSpectator
approved these changes
Sep 27, 2024
|
I'm curious: why does Yetus show more errors when we backport PRs into 12.0?.. Have we changed anything in the Yetus config since then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error types very often have private members that cannot be marshalled with
json.Marshalwe fix this by only storing the error type and the error string (err.Error()) as values in uppercase members of our own ioBundleError type
log output:
introduced by d1e13b8
Signed-off-by: Christoph Ostarek [email protected]
(cherry picked from commit 9cc6ca8)