Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview flag doesnt work properly #48

Open
Cynosphere opened this issue Mar 18, 2021 · 3 comments
Open

Preview flag doesnt work properly #48

Cynosphere opened this issue Mar 18, 2021 · 3 comments
Labels
question Further information is requested

Comments

@Cynosphere
Copy link

.\install.ps1 -PreRelease
Use Default layout.
Found Windows Terminal version 1.0.1401.0.
Found Windows Terminal version 1.6.10571.0.
Found Windows Terminal version 1.6.10412.0.
Found Windows Terminal version 1.7.572.0.
Found actual executable C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.7.572.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe.
WARNING: Didn't find icon for profile .
CreateMenuItem: D:\Downloads\install.ps1:371
Line |
 371 |          CreateMenuItem $rootKey $name $profileIcon $command $false
     |                                  ~~~~~
     | Cannot bind argument to parameter 'name' because it is an empty string.

CreateMenuItem: D:\Downloads\install.ps1:372
Line |
 372 |          CreateMenuItem $rootKeyElevated $name $profileIcon $elevated  …
     |                                          ~~~~~
     | Cannot bind argument to parameter 'name' because it is an empty string.

Windows Terminal installed to Windows Explorer context menu.

It only gave me options for the normal build along with erroring

@Cynosphere
Copy link
Author

Apparently I had an empty object in my profile list causing the error. It still doesn't link to Preview when creating menu objects though.

@Cynosphere
Copy link
Author

Cynosphere commented Mar 18, 2021

$executable = "$Env:LOCALAPPDATA\Microsoft\WindowsApps\wt.exe"

This should refer to Microsoft.WindowsTerminal(Preview)_8wekyb3d8bbwe\wt.exe instead, depending on $PreRelease or not.

@lextm lextm added the question Further information is requested label Mar 18, 2021
@lextm
Copy link
Owner

lextm commented Mar 18, 2021

More investigation is needed before this item can be worked on,

  1. Cannot find Microsoft.WindowsTerminal(Preview)_8wekyb3d8bbwe\wt.exe on my machine. It seems to be $Env:LOCALAPPDATA\Microsoft\WindowsApps\Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe\wt.exe.
  2. On my machine $Env:LOCALAPPDATA\Microsoft\WindowsApps\wt.exe is associated with the preview version. So it seems that this shortcut is not a reliable one and should be changed anyway.

Once investigation is done, we might ship a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants