Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.webp format not supported anymore #15

Open
Arno989 opened this issue May 24, 2020 · 3 comments
Open

.webp format not supported anymore #15

Arno989 opened this issue May 24, 2020 · 3 comments
Labels
question Further information is requested

Comments

@Arno989
Copy link

Arno989 commented May 24, 2020

In my last version of the script (about 11 days ago or something) I used a .webp image for my python icon and it worked flawlessly, but now I get an error
image
This is probably a handling in icon images you've added but since I haven had any problems with random formats and sizes I don't understand the change.

@lextm
Copy link
Owner

lextm commented May 24, 2020

Windows Terminal supports a variety of image formats, but Windows Explorer context menu only supports .ico.

In order to keep the script simple, it is intentional to only support .ico files, but .png files are also supported (because we need to read cached images from Windows Terminal's folders which are in .png format). That's why there was a warning.

I will try to revise the script to eliminate the errors though.

Workaround: You can always use another tool to convert .webp to .png or .ico.

@lextm lextm added the question Further information is requested label May 24, 2020
@Arno989
Copy link
Author

Arno989 commented May 24, 2020

Yeah I thought of the workaround as last resort because I find it annoying if I have to go and convert images to icons and stuff, always takes way longer that it's supposed to and I hate doing it.

I was extremely pleasantly surprised when the .webp just worked out of the box so it was quite a bummer to then see that it didn't anymore. But thanks for looking into it anyway.

@lextm
Copy link
Owner

lextm commented May 24, 2020

Sounds like it might be possible to use Windows 10's builtin API, https://github.com/DavidAnson/ConvertTo-Jpeg/blob/master/ConvertTo-Jpeg.ps1

Will leave this issue open for a few days to see if that API can be reused for .webp to .ico conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants