From 6d75d68bd815f91215bc42c2559733ecd5b034df Mon Sep 17 00:00:00 2001 From: DeDe Morton Date: Tue, 27 Mar 2018 00:05:24 -0700 Subject: [PATCH] Remove old reviewer notes (#6655) --- filebeat/docs/modules/kafka.asciidoc | 13 ------------- filebeat/docs/modules/traefik.asciidoc | 2 -- filebeat/module/kafka/_meta/docs.asciidoc | 13 ------------- filebeat/module/traefik/_meta/docs.asciidoc | 2 -- 4 files changed, 30 deletions(-) diff --git a/filebeat/docs/modules/kafka.asciidoc b/filebeat/docs/modules/kafka.asciidoc index 1c1e4dd4ace..a6b903d4c95 100644 --- a/filebeat/docs/modules/kafka.asciidoc +++ b/filebeat/docs/modules/kafka.asciidoc @@ -45,11 +45,6 @@ file to override the default paths for logs: ----- -// REVIEWERS: I must be doing something wrong with the config settings. The -// above config works, but when I try to specify var.kafka_home, it doesn't -// seem to have any effect. - - To specify the same settings at the command line, you use: ["source","sh",subs="attributes"] @@ -66,14 +61,6 @@ include::../include/config-option-intro.asciidoc[] [float] ==== `log` fileset settings -// REVIEWERS: I've added a description because this variable appears in the -// kafka.yml file. However, I don't understand how it works. - -//*`var.kafka_home`*:: - -//The home path for Kafka. If this variable is not set, {beatname_uc} looks under -//`/opt`. - include::../include/var-paths.asciidoc[] diff --git a/filebeat/docs/modules/traefik.asciidoc b/filebeat/docs/modules/traefik.asciidoc index aecee8ac979..ad56271afb9 100644 --- a/filebeat/docs/modules/traefik.asciidoc +++ b/filebeat/docs/modules/traefik.asciidoc @@ -19,8 +19,6 @@ This module requires the {elasticsearch-plugins}/ingest-user-agent.html[ingest-user-agent] and {elasticsearch-plugins}/ingest-geoip.html[ingest-geoip] Elasticsearch plugins. -//REVIEWERS: Do we need to say anything else about compatibility here? - include::../include/running-modules.asciidoc[] [float] diff --git a/filebeat/module/kafka/_meta/docs.asciidoc b/filebeat/module/kafka/_meta/docs.asciidoc index 9bbaa14cb9d..bdce41e9626 100644 --- a/filebeat/module/kafka/_meta/docs.asciidoc +++ b/filebeat/module/kafka/_meta/docs.asciidoc @@ -40,11 +40,6 @@ file to override the default paths for logs: ----- -// REVIEWERS: I must be doing something wrong with the config settings. The -// above config works, but when I try to specify var.kafka_home, it doesn't -// seem to have any effect. - - To specify the same settings at the command line, you use: ["source","sh",subs="attributes"] @@ -61,12 +56,4 @@ include::../include/config-option-intro.asciidoc[] [float] ==== `log` fileset settings -// REVIEWERS: I've added a description because this variable appears in the -// kafka.yml file. However, I don't understand how it works. - -//*`var.kafka_home`*:: - -//The home path for Kafka. If this variable is not set, {beatname_uc} looks under -//`/opt`. - include::../include/var-paths.asciidoc[] diff --git a/filebeat/module/traefik/_meta/docs.asciidoc b/filebeat/module/traefik/_meta/docs.asciidoc index 1dd1def3140..6264e00fd18 100644 --- a/filebeat/module/traefik/_meta/docs.asciidoc +++ b/filebeat/module/traefik/_meta/docs.asciidoc @@ -14,8 +14,6 @@ This module requires the {elasticsearch-plugins}/ingest-user-agent.html[ingest-user-agent] and {elasticsearch-plugins}/ingest-geoip.html[ingest-geoip] Elasticsearch plugins. -//REVIEWERS: Do we need to say anything else about compatibility here? - include::../include/running-modules.asciidoc[] [float]