Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is phantom needed as a dependency? #41

Open
tnguyen14 opened this issue Dec 4, 2017 · 2 comments
Open

Why is phantom needed as a dependency? #41

tnguyen14 opened this issue Dec 4, 2017 · 2 comments

Comments

@tnguyen14
Copy link

Why is phantom needed as a dependency instead of devDependency?

My install of svg-icon failed because installing phantomjs-prebuilt needs to call out to the internet, which fails inside our CI environment.
@tnguyen14
Copy link
Author

I see that #29 will remove phantom, but in the meantime, can it be moved to devDependencies?

/cc @leungwensen

@leungwensen
Copy link
Owner

hn... phantom will be removed before 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tnguyen14 @leungwensen