Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip '/' and use osp.join (Windows support) #283

Merged
merged 4 commits into from
Nov 3, 2023
Merged

strip '/' and use osp.join (Windows support) #283

merged 4 commits into from
Nov 3, 2023

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Nov 3, 2023

Fixes bad path issues, from Discord:

It looks like the os.sep is not being used in the path.
persistence.pickle failed with: [Errno 2] No such file or directory: 'C:\Users\xxx.memgpt/saved_state\2023-11-03_04_57_10_AM_PDT-0700.persistence.pickle
As you can see there is an error due to the forward slash being used instead of the back slash right after .memgpt directory

@cpacker cpacker requested a review from sarahwooders November 3, 2023 16:59
@cpacker cpacker requested a review from vivi November 3, 2023 17:01
@cpacker cpacker changed the title strip '/' and use osp.join strip '/' and use osp.join (Windows support) Nov 3, 2023
vivi
vivi approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@vivi vivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕺

@vivi vivi merged commit 4c80222 into main Nov 3, 2023
2 checks passed
@cpacker cpacker deleted the fix-os-sep branch November 4, 2023 02:27
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
@cpacker @vivi
strip '/' and use osp.join (Windows support) (#283)
4cc6104 
* strip '/' and use osp.join

* grepped for MEMGPT_DIR, found more places to replace '/'

* typo

* grep pass over filesep

---------

Co-authored-by: Vivian Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivi vivi vivi approved these changes

@sarahwooders sarahwooders Awaiting requested review from sarahwooders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpacker @vivi