Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create new request model that drops user_id #2220

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: create new request model that drops user_id #2220

merged 1 commit into from
Dec 11, 2024

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Dec 10, 2024 •
edited
Loading

Don't show / require the user_id in the CreateAgent request model (it's confusing to developers, since end-user ID tracking should be done via tags, not via the user_id field).

This should drop the value from the generated openapi.json schema as well.

@cpacker cpacker requested a review from sarahwooders December 10, 2024 22:52
@sarahwooders sarahwooders merged commit c9c2cca into main Dec 11, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahwooders sarahwooders sarahwooders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpacker @sarahwooders