Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GET REST API route for listing tools #1100

Merged
merged 4 commits into from
Mar 6, 2024
Merged

feat: add GET REST API route for listing tools #1100

merged 4 commits into from
Mar 6, 2024

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Mar 6, 2024 •
edited
Loading

Please describe the purpose of this pull request.

  • Adds a basic GET REST API route to enable listing of tools (eg to fill a tool view)
  • TODOs for future PRs:
    • Rewrite tool models into SQLModel
    • Figure out how we want to persist custom functions/tools in the database
      • How to handle source? Just as strings?
        • e.g. model.source_code + model.source_type (== 'python')
      • If source is strings, how to handle the validation?

Have you tested this PR?

image

@cpacker cpacker added the API Related to MemGPT API label Mar 6, 2024
@cpacker cpacker marked this pull request as ready for review March 6, 2024 06:05
sarahwooders
sarahwooders approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cpacker cpacker merged commit e6ffbc2 into main Mar 6, 2024
4 checks passed
@cpacker cpacker deleted the tools-rest-api branch March 6, 2024 06:11
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
@cpacker
feat: add GET REST API route for listing tools (#1100)
a21640a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahwooders sarahwooders sarahwooders approved these changes

Assignees
No one assigned
Labels
API Related to MemGPT API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpacker @sarahwooders