feat: isolate test config from main config #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbedor-square2
force-pushed
the
tombedor.test-config
branch
from
07bf01d
to
5a345f9
Compare
tbedor-square2
force-pushed
the
tombedor.test-config
branch
3 times, most recently
from
0aa90a9
to
dfd812d
Compare
tbedor-square2
force-pushed
the
tombedor.test-config
branch
from
53b79eb
to
8425be5
Compare
tombedor
force-pushed
the
tombedor.test-config
branch
from
8425be5
to
e1cecc0
Compare
allow for directing test config to a different variable than the main app config. also set the stage for making MemGPTConfig a constant, rather than a function argument.
tombedor
force-pushed
the
tombedor.test-config
branch
from
e1cecc0
to
499a7bf
Compare
cpacker
approved these changes
Mar 6, 2024
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Charles Packer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow for directing test config to a different variable than the main app config.
also set the stage for making MemGPTConfig a constant, rather than a function argument.