-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tests and bug fixes AgentState.state
#1058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpacker
changed the title
feat: add tests for read/writes on
feat: tests and bug fixes Feb 26, 2024
AgentState.state
AgentState.state
This was
linked to
issues
Feb 29, 2024
… creation code to new preset-in-agent-init method
cpacker
commented
Mar 1, 2024
sarahwooders
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
Another attempt to patch #966 (closes #966)
AgentState.state
tests/test_metadata_store.py
(maybe should be put elsewhere?)agent_state.state
, read from the preset insteadagent_state.state
(should no longer error)create_agent_from_preset
, instead modifyAgent.__init__
to take optionalpreset
argHow to test
Have you tested this PR?
Repro issue (0.3.3)
Roll back to version
0.3.3
:Wipe existing home dir:
Try to repro based on #1070:
Repro issue (
main
)Roll back to version to main (pre-PR #1058):
Wipe existing home dir:
Try to repro based on #1070:
@sarahwooders bug reported in #1070 was fixed sometime past the
0.3.3
tag, but pre-this PR.Confirm that PR patches the issueEnsuring that there was no regression in this PR