fix: patch /rewrite
#1034
Merged
fix: patch /rewrite
#1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpacker
commented
Feb 20, 2024
cpacker
commented
Feb 20, 2024
| @@ -615,6 +615,15 @@ def run( | |||
| # create agent | |||
| try: | |||
| preset = ms.get_preset(preset_name=agent_state.preset, user_id=user.id) | |||
| if preset is None: | |||
There was a problem hiding this comment.
Without this I think the user will get an error until they run memgpt configure when going from 0.3.x -> 0.3.3
cpacker
commented
Feb 20, 2024
cpacker
commented
Feb 20, 2024
memgpt/agent_store/db.py
Outdated
| @@ -491,6 +491,24 @@ def insert(self, record: Record, exists_ok=True): | |||
| self.insert_many([record], exists_ok=exists_ok) | |||
|
|
|||
|
|
|||
| def update(self, record: RecordType): | |||
There was a problem hiding this comment.
This is untested (though the unit test should theoretically check it?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
/rewriteallows rewriting the message an agent sent/rewritecommand to instead modify the underlyingMessageDB object, so it will properly persistHow to test
Try
/rewriteand see if (1) the message is rewritten in the buffer (is in/dump), and (2) that it persists on a load (/exitand reopen the agent, then/dump)Have you tested this PR?
Yes, with the SQLite + Chroma backend:
/rewriteon a fresh agent