Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFE: Use JSON tags to omit the Authorization ID and RegistrationID fields #7769

Merged
merged 2 commits into from
Oct 28, 2024
Merged

WFE: Use JSON tags to omit the Authorization ID and RegistrationID fields #7769

merged 2 commits into from
Oct 28, 2024

Conversation

beautifulentropy
Copy link
Member

Use the - JSON tag to omit ID and RegistrationID fields instead of mutating the core.Authorization object.

@beautifulentropy beautifulentropy marked this pull request as ready for review October 25, 2024 17:47
@beautifulentropy beautifulentropy requested a review from a team as a code owner October 25, 2024 17:47
jsha
jsha approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

aarongable
aarongable reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think there's room to go further than this -- e.g. prepAccountForDisplay zeroes out two fields, and prepChallengeForDisplay nils a nested field. Up to you whether you want to include those in this same PR or a followup.

@beautifulentropy beautifulentropy mentioned this pull request Oct 28, 2024
Open
@beautifulentropy
Copy link
Member Author

LGTM. I think there's room to go further than this -- e.g. prepAccountForDisplay zeroes out two fields, and prepChallengeForDisplay nils a nested field. Up to you whether you want to include those in this same PR or a followup.

#7774 filed.

@beautifulentropy beautifulentropy merged commit b69c005 into main Oct 28, 2024
12 checks passed
@beautifulentropy beautifulentropy deleted the wfe-do-not-mutate-id-regid branch October 28, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable approved these changes

@jsha jsha jsha approved these changes

@jprenken jprenken Awaiting requested review from jprenken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beautifulentropy @jsha @aarongable