Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: provide a "check against defaults" function #5229

Closed
aarongable opened this issue Jan 14, 2021 · 0 comments · Fixed by #7204
Closed

Features: provide a "check against defaults" function #5229

aarongable opened this issue Jan 14, 2021 · 0 comments · Fixed by #7204

Comments

@aarongable
Copy link
Contributor

The features package currently provides a .reset() method, which the tests use extensively in order to ensure that any feature flags which were set by individual tests get cleared before other tests run.

However, this method often gets called in shared setup code, which can accidentally clear feature flags which were purposefully set by an individual test before it gets to the actual test logic.

The features package should also provide a "check against the defaults" method which returns an error if any flags have been modified. Then that can be used in the shared setup code, to error out and enforce that every individual test case cleans up after itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant