Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support creating a webserver config for apache/nginx #59

Open
tosmi opened this issue Apr 16, 2016 · 2 comments
Open

support creating a webserver config for apache/nginx #59

tosmi opened this issue Apr 16, 2016 · 2 comments

Comments

@tosmi
Copy link
Contributor

tosmi commented Apr 16, 2016

cristifalcas/kibana supports creating an apache vhost or nginx config entry to serve kibana behind a web server, which we would like to use. if it's ok, i'm going to implement this for this module as well and create a PR (i'm going to let myself be inspired by cristifalcas/kibana).

thanks toni

@lesaux
Copy link
Owner

lesaux commented Apr 16, 2016

Hi Tosmi, this is useful, but couldn't this be achieved using the apache or nginx puppet modules?

@tosmi
Copy link
Contributor Author

tosmi commented Apr 17, 2016

absolutely, i would just add a manifest that adds an apache::vhost entry. e.g. like

https://github.com/cristifalcas/puppet-kibana/blob/master/manifests/proxy/apache.pp

but after sleeping one night over the idea, maybe this could also be implemented in a profile. dunno, if you say yes that's going to be useful, i'll send a PR. if you think, baah not in my module, i'm also ok.

toni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants