Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Deprecations #29

Open
vemv opened this issue Aug 6, 2021 · 2 comments
Open

Deprecations #29

vemv opened this issue Aug 6, 2021 · 2 comments

Comments

@vemv
Copy link

vemv commented Aug 6, 2021

Hi,

great library 🙌

I noticed that it uses a number of deprecated Java methods. For example lein eastwood reports 30+ deprecations in the lettuce-core module.

Here's a brief sampler:

src/celtuce/impl/cluster.clj:394:15: deprecations: Instance method 'public abstract java.util.List io.lettuce.core.api.sync.RedisSortedSetCommands.zrangebylex(java.lang.Object,java.lang.String,java.lang.String)' is deprecated.
src/celtuce/impl/cluster.clj:396:15: deprecations: Instance method 'public abstract java.util.List io.lettuce.core.api.sync.RedisSortedSetCommands.zrangebylex(java.lang.Object,java.lang.String,java.lang.String,long,long)' is deprecated.
src/celtuce/impl/cluster.clj:314:5: deprecations: Instance method 'public abstract java.lang.Long io.lettuce.core.api.sync.RedisSortedSetCommands.zcount(java.lang.Object,double,double)' is deprecated.

It seems a good idea to eventually fix them so that one can continue to upgrade Lettuce (which can always be needed for various reasons) seamlessly.

Cheers - V

@lerouxrgd
Copy link
Owner

Hi, I'd gladly accept a PR to update those !

@vemv
Copy link
Author

vemv commented Aug 7, 2021

Fair enough, it might not be that difficult since every deprecation note tells you what to use instead

Might give it a shot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants