Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require_oauth.acquire imposes a memory limit #485

Closed
cariaso opened this issue Aug 30, 2022 · 1 comment
Closed

require_oauth.acquire imposes a memory limit #485

cariaso opened this issue Aug 30, 2022 · 1 comment
Labels
server

Comments

@cariaso
Copy link

cariaso commented Aug 30, 2022 •
edited
Loading

authlib/authlib/integrations/flask_oauth2/resource_protector.py

Line 73 in 169c7dc

_req.data,

require_oauth.acquire cannot be used to protect large POSTs, where the data will be streamed, because the usage of _req.data on line 73 fills memory. Replacing _req.data with a simple None seems to allow the correct result to be computed, but damages the downstream computation.
@lepture lepture added the server label Sep 25, 2022
@lepture
Copy link
Owner

lepture commented Sep 25, 2022

fixed in 3c34fec

@lepture lepture closed this as completed Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cariaso @lepture