-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#268 #269 Improve HTTPX Support #270
Conversation
…e content-length header si not specific
@berzoidberg I'm not ready to support sync mode of httpx. currently httpx is not stable, it has many breaking changes. For example, I have locked httpx version to |
I can get that done. 0.14.3 is the latest, should I aim to get tests working with that version instead? |
@lepture Successfully updated to work w/HTTPX 0.14.3 -- the newest available. |
add support for httpx sync APIs; fix bug in httpx oauth1 support where content-length header si not specific update to httpx 0.14.3 Remove deprecated and purely cosmetical argument providing_args in Django integrations add test and fix for unintentional parallel token refreshes update to work with latest master
…authlib into improve-httpx-support
Actually, we had HTTPX sync API before, in version 0.13. But later after we released 0.13, HTTPX removed sync API for a while. |
Aye, in HTTPX 0.13.0 they released the new sync client, sync and async both use the same codebase with some minor interface differences now. I'll gladly volunteer to continue maintaining HTTPX support as they make changes if we can get this merged up. |
@lepture thanks for the review, i removed the unnecessary bits from all 3 client types (assertion, oauth1, oauth2) |
ee66053
to
340168b
Compare
Fixes #268
Fixes #269
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Yes
No
You consent that the copyright of your pull request source code belongs to Authlib's author.