Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit AGP version (now provided by RNGP) #1482

Closed
leotm opened this issue Feb 7, 2023 · 1 comment
Closed

Remove explicit AGP version (now provided by RNGP) #1482

leotm opened this issue Feb 7, 2023 · 1 comment
Labels
agp Android Gradle Plugin android Native Android changes (Java, Gradle, Kotlin) cmake Generate another system's build files priority: low react native react-native-community.github.io/upgrade-helper rngp React Native Gradle Plugin
Milestone
React Native 0.71

Comments

@leotm
Copy link
Owner

leotm commented Feb 7, 2023 •
edited
Loading

Landed in main

... removed the explicit version in the template as now the AGP version
is provided by RNGP. That means that the user will get the correct version they need.

So Update

react-native-template-new-architecture/android/build.gradle

Line 19 in 5bac8f4

classpath("com.android.tools.build:gradle:7.4.1")

Future RN.x cherry-pick landing in future upgrade-helper diff

Not 0.71.3

... bumps the default CMake version in user space to 3.22 which resolves a lot
of warning when users are building with the New Architecture enabled.

Re-check CMake CI ver (ref: 393df77) and local 3.25

Test CI w 3.26.0-rc.1?
@leotm leotm added react native react-native-community.github.io/upgrade-helper android Native Android changes (Java, Gradle, Kotlin) cmake Generate another system's build files agp Android Gradle Plugin rngp React Native Gradle Plugin labels Feb 7, 2023
@leotm leotm added this to the React Native 0.71 milestone Feb 7, 2023
@leotm
Copy link
Owner Author

leotm commented Apr 2, 2023 •
edited
Loading

  • allow @renovate-bot upgrades to latest
    • like tracking react-native-codegen
  • allow testing pre-release vers

@leotm leotm closed this as completed Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agp Android Gradle Plugin android Native Android changes (Java, Gradle, Kotlin) cmake Generate another system's build files priority: low react native react-native-community.github.io/upgrade-helper rngp React Native Gradle Plugin
Projects
None yet
Milestone
React Native 0.71
Development

No branches or pull requests
1 participant
@leotm