Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): add Divider component #52

Merged
merged 4 commits into from
Jul 5, 2022

Conversation

niloysikdar
Copy link
Member

@niloysikdar niloysikdar commented Jul 3, 2022

This Pull Request covers:

  • New component Divider
  • Stories for newly added component
  • Props for the component
export interface BaseStyleProp<T extends string> {
  classes?: Partial<Record<T, CSSProperties>>;
  className?: string;
}

export interface DividerProps extends BaseStyleProp<DividerStyles> {
  align?: 'left' | 'center' | 'right';
}

Resolves #44

Signed-off-by: Niloy Sikdar [email protected]

add new Divider component

resolves #44

Signed-off-by: Niloy Sikdar <[email protected]>
add new stories for new Divider component

resolves #44

Signed-off-by: Niloy Sikdar <[email protected]>
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Jul 3, 2022
@niloysikdar niloysikdar marked this pull request as ready for review July 5, 2022 17:02
src/components/Divider/Divider.stories.tsx Outdated Show resolved Hide resolved
src/components/Divider/Divider.stories.tsx Outdated Show resolved Hide resolved
src/components/Divider/Divider.stories.tsx Outdated Show resolved Hide resolved
fix Divider component structure to use hr and update the stories

resolves #44

Signed-off-by: Niloy Sikdar <[email protected]>
@niloysikdar niloysikdar force-pushed the feat/44-add-component-divider branch from 9bcfb46 to ac806d9 Compare July 5, 2022 17:49
@agentmilindu agentmilindu merged commit eb301f4 into main Jul 5, 2022
@agentmilindu agentmilindu deleted the feat/44-add-component-divider branch July 5, 2022 17:55
github-actions bot pushed a commit that referenced this pull request Jul 5, 2022
# [1.3.0](v1.2.1...v1.3.0) (2022-07-05)

### Features

* **component:** add Divider component ([#52](#52)) ([eb301f4](eb301f4)), closes [#44](#44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add component: Divider
2 participants