-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): add Image component #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new Image component to render images resolves #42 Signed-off-by: Niloy Sikdar <[email protected]>
add stories for image component using storybook resolves #42 Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar
added
the
GSoC 2022
Issues and Pull Requests under Google Summer of Code 2022
label
Jul 3, 2022
agentmilindu
reviewed
Jul 3, 2022
Merge main branch with the latest changes Signed-off-by: Niloy Sikdar <[email protected]>
fix the Image component with new structure and props resolves #42 Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar
force-pushed
the
feat/42-add-component-image
branch
from
July 8, 2022 19:10
555cb1f
to
d82b94a
Compare
niloysikdar
force-pushed
the
feat/42-add-component-image
branch
from
July 9, 2022 18:34
d82b94a
to
fcfb301
Compare
niloysikdar
force-pushed
the
feat/42-add-component-image
branch
from
July 11, 2022 11:57
fcfb301
to
e17f965
Compare
niloysikdar
force-pushed
the
feat/42-add-component-image
branch
from
July 11, 2022 12:00
e17f965
to
b0c9673
Compare
- Fix Image component with updated structure and props - Fix Section and Column props - Update stories for Image component resolves #42 Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar
force-pushed
the
feat/42-add-component-image
branch
from
July 11, 2022 16:49
b0c9673
to
203f0f9
Compare
agentmilindu
approved these changes
Jul 11, 2022
🎉 This PR is included in version 1.5.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request covers:
Image
Resolves #42
Signed-off-by: Niloy Sikdar [email protected]