Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromSb3: Fix loading undefined sb3Block.next #146

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fromSb3: Fix loading undefined sb3Block.next #146

merged 2 commits into from
Jun 17, 2024

Commits on May 30, 2024

  1. fromSb3: handle undefined sb3Block.next 

    Also cleans up the parameters for blockWithNext.
    @towerofnix
    towerofnix committed May 30, 2024
    Configuration menu
    Copy the full SHA
    5c6c6b9 View commit details
    Browse the repository at this point in the history

  2. fromSb3: don't re-run getBlockScript redundantly 

    getBlockScript returns a function which is useful for getting any
top-level script, and getBlockScript only operates on the total
list of the target's blocks, which doesn't change dependant on the
script you are trying to access. So use it like the currying
function it presents itself as and don't re-run getBlockScript
for every script in the target.
    @towerofnix
    towerofnix committed May 30, 2024
    Configuration menu
    Copy the full SHA
    89c55d2 View commit details
    Browse the repository at this point in the history