fromSb3: Fix loading undefined sb3Block.next #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleans up the parameters for blockWithNext.
getBlockScript returns a function which is useful for getting any top-level script, and getBlockScript only operates on the total list of the target's blocks, which doesn't change dependant on the script you are trying to access. So use it like the currying function it presents itself as and don't re-run getBlockScript for every script in the target.
towerofnix
added
bug
PullJosh
reviewed
Jun 13, 2024
PullJosh
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development:
See #143 for some technical discussion.
Best to view the commits separately, as they are independent changes, though they affect the same area of code.
nexton blocks in a project.json not crashfromSb3. This may be a omission by a minifier used in the demo project, rather than something Scratch itself will ever serialize, though Scratch handles deserializing undefinednextjust fine, so sb-edit should too.blockWithNextis sometimes called without itsparentIdargument so we just make itparentId?: stringinstead ofparentId: string | undefined. AndgetBlockScript, previously called once for each script in a target, is now called just once for each target, becausegetBlockScriptdoes not care which script you're about to get, and is structured to make all scripts available. (It's a currying function, so now we use it like one!)Tested manually with the project shared in #141, WebOMatic!.