fix various minor lint errors

leopard-js · Dec 16, 2023 · 89ee610 · 89ee610
1 parent 02a091f
commit 89ee610
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/src/BlockInput.ts b/src/BlockInput.ts
@@ -92,7 +92,7 @@ export interface SoundEffect extends Base {
 
 export interface GoToTarget extends Base {
   type: "goToTarget";
-  value: "_random_" | "_mouse_" | string;
+  value: string; // Specially handled: _mouse_, _random_
 }
 
 export interface PointTowardsTarget extends Base {
@@ -236,7 +236,7 @@ export interface CloneTarget extends Base {
 
 export interface TouchingTarget extends Base {
   type: "touchingTarget";
-  value: "_mouse_" | string;
+  value: string; // Specially handled: _mouse_
 }
 
 export interface DistanceToMenu extends Base {

diff --git a/src/io/leopard/toLeopard.ts b/src/io/leopard/toLeopard.ts
@@ -1,6 +1,6 @@
 import Project from "../../Project";
 import Script from "../../Script";
-import Block, { BlockBase } from "../../Block";
+import Block from "../../Block";
 import * as BlockInput from "../../BlockInput";
 import { OpCode } from "../../OpCode";
 
@@ -398,15 +398,15 @@ export default function toLeopard(
     desiredInputShape?: InputShape
   ): string {
     // Short-circuit for string inputs. These must never return number syntax.
-    if (desiredInputShape === "string") {
+    if (desiredInputShape === InputShape.String) {
       return JSON.stringify(value);
     }
 
     // Other input shapes which static inputs may fulfill: number, index, any.
     // These are all OK to return JavaScript number literals for.
     const asNum = Number(value as string);
     if (!isNaN(asNum) && value !== "") {
-      if (desiredInputShape === "index") {
+      if (desiredInputShape === InputShape.Index) {
         return JSON.stringify(asNum - 1);
       } else {
         return JSON.stringify(asNum);
@@ -1835,19 +1835,19 @@ export default function toLeopard(
         return blockSource;
       }
 
-      if (desiredInputShape === "boolean") {
+      if (desiredInputShape === InputShape.Boolean) {
         return `(this.toBoolean(${blockSource}))`;
       }
 
-      if (desiredInputShape === "string") {
+      if (desiredInputShape === InputShape.String) {
         return `(this.toString(${blockSource}))`;
       }
 
-      if (desiredInputShape === "number") {
+      if (desiredInputShape === InputShape.Number) {
         return `(this.toNumber(${blockSource}))`;
       }
 
-      if (desiredInputShape === "index") {
+      if (desiredInputShape === InputShape.Index) {
         return `((${blockSource}) - 1)`;
       }
 

diff --git a/src/io/sb3/fromSb3.ts b/src/io/sb3/fromSb3.ts
@@ -8,7 +8,7 @@ import * as BlockInput from "../../BlockInput";
 import Costume from "../../Costume";
 import Project from "../../Project";
 import Sound from "../../Sound";
-import Target, { Sprite, Stage, TargetOptions } from "../../Target";
+import { Sprite, Stage, TargetOptions } from "../../Target";
 import { List, Variable } from "../../Data";
 import Script from "../../Script";
 
@@ -104,7 +104,7 @@ function getBlockScript(blocks: { [key: string]: sb3.Block }) {
             // We basically just want to copy the important
             // information from the shadow block down into
             // the block containing the shadow.
-            if (block.opcode === "procedures_prototype") {
+            if (block.opcode === OpCode.procedures_prototype) {
               const mutation = (block as sb3.Block<OpCode.procedures_prototype>).mutation;
 
               // Split proccode (such as "letter %n of %s") into ["letter", "%n", "of", "%s"]