Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix signing payloads > 256 bytes #419

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented Feb 3, 2024

Closes #418

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (653d39a) 48.85% compared to head (ba547c6) 48.84%.
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   48.85%   48.84%   -0.02%     
==========================================
  Files         177      177              
  Lines        9443     9445       +2     
==========================================
  Hits         4613     4613              
- Misses       4830     4832       +2     
Flag Coverage Δ
polkadart 16.82% <0.00%> (-0.03%) ⬇️
polkadart_cli 12.04% <ø> (ø)
polkadart_keyring 71.76% <ø> (ø)
polkadart_scale_codec 54.93% <ø> (ø)
secp256k1_ecdsa 90.00% <ø> (ø)
sr25519 85.91% <ø> (ø)
ss58 96.87% <ø> (ø)
substrate_bip39 56.37% <ø> (ø)
substrate_metadata 87.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...kages/polkadart/lib/extrinsic/signing_payload.dart 0.00% <0.00%> (ø)

@leonardocustodio leonardocustodio merged commit ded9a84 into leonardocustodio:main Feb 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad signature error for signing payloads > 256 bytes
2 participants