Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to leave subject capitilized #82

Closed
rylek90 opened this issue Apr 5, 2019 · 2 comments · May be fixed by satoshinakamoto007/bitcore#1119
Closed

Add possibility to leave subject capitilized #82

rylek90 opened this issue Apr 5, 2019 · 2 comments · May be fixed by satoshinakamoto007/bitcore#1119

Comments

@rylek90
Copy link
Contributor

rylek90 commented Apr 5, 2019

Since, there's a rule https://conventional-changelog.github.io/commitlint/#/reference-rules?id=subject-case to enforce subject's case.

For people using cz-customizable along with commitlint it'd be nice to have possibility to leave subject as is (do not make it lowercase).

AC:

  • Add { lowerCaseSubject } with default true to configuration.
  • When loweCaseSubject === false do not transform subject from This is subject to this is subject

I can push a PR for this soon if no one will pick this.

@leonardoanalista
Copy link
Member

I like it! Default value sounds good, no breaking changes.
Feel free to decide between “upperCaseSubject” with default false or your suggestion

rylek90 added a commit to rylek90/cz-customizable that referenced this issue Apr 5, 2019
@leonardoanalista
Copy link
Member

🎉 This issue has been resolved in version 5.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants