Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to skip footer prefix #73

Closed
rylek90 opened this issue Apr 3, 2019 · 2 comments · May be fixed by satoshinakamoto007/bitcore#1119
Closed

Add possibility to skip footer prefix #73

rylek90 opened this issue Apr 3, 2019 · 2 comments · May be fixed by satoshinakamoto007/bitcore#1119
Labels
feature New features of enhancement of existing ones

Comments

@rylek90
Copy link
Contributor

rylek90 commented Apr 3, 2019 •
edited
Loading

Currently there's no option to skip { footerPrefix } by setting it to empty string.

Sometimes commit only references (or partially fixes) specific issues without need to automatically close them as described in https://help.github.com/en/articles/closing-issues-using-keywords

Acceptance criteria:
Configuration should accept { footerPrefix: '' } or { skipFooterPrefix: true } and produce commit with following footer:

whatever developer typed here
@rylek90 rylek90 changed the title Empty string as footerPrefix should be respected Add possibility to skip footer prefix Apr 3, 2019
rylek90 added a commit to rylek90/cz-customizable that referenced this issue Apr 3, 2019
@rylek90
feat: add possibility to set empty footerPrefix
e36acf6 
ISSUES CLOSED: leoforfree#73
@leonardoanalista
Copy link
Member

it sounds good to me. Thank you!

@leonardoanalista leonardoanalista added the feature New features of enhancement of existing ones label Apr 3, 2019
@leonardoanalista leonardoanalista mentioned this issue Apr 3, 2019
Merged
rylek90 added a commit to rylek90/cz-customizable that referenced this issue Apr 4, 2019
@rylek90
feat: add possibility to set empty footerPrefix
28e8fdd 
ISSUES CLOSED: leoforfree#73
@leonardoanalista
Copy link
Member

🎉 This issue has been resolved in version 5.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@satoshinakamoto007 satoshinakamoto007 mentioned this issue Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New features of enhancement of existing ones
Projects
None yet
Milestone
No milestone
2 participants
@leonardoanalista @rylek90