The "remote" example from the README doesn't appear to work

[aktau]

From the README:

lua require('dap-go').setup {
  dap_configurations = {
    {
      type = "go",
      name = "Attach remote",
      mode = "remote",
      request = "attach",
    },
  },
}

So I tried to connect to a running dlv dap, and it connects alright (after I hard-code the port), but then immediately I get that dlv exits with code 1. After reading nvim-dap docs, I figure this is due to the following:

nvim-dap-go/lua/dap-go.lua

Lines 69 to 81 in 6aa8816

	local delve_config = {
	type = "server",
	port = config.delve.port,
	executable = {
	command = config.delve.path,
	args = args,
	detached = config.delve.detached,
	cwd = config.delve.cwd,
	},
	options = {
	initialize_timeout_sec = config.delve.initialize_timeout_sec,
	},
	}

.

As it turns out, if an executable attribute is set, mfussenegger/nvim-dap will spawn that executable, even when request = "attach". This is incognruent with mode = "remote". Docs: https://github.com/mfussenegger/nvim-dap/blob/580d6e526358afd0e4bba053e68fd59cf581a161/doc/dap.txt#L76-L78.

So I fixed my problem by commenting out that executable section. It'd probably make sense to make this executable section depend on whether or not mode == "remote".