Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shell special characters escaping #108

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

dudekaa
Copy link
Contributor

@dudekaa dudekaa commented Dec 10, 2019

ISSUES CLOSED: #107

@leonardoanalista
Copy link
Member

@dudekaa it sounds like a good PR. If you rebase it, we merge it 👍

@dudekaa
Copy link
Contributor Author

dudekaa commented Jul 14, 2022

@leonardoanalista 🎉 and thanks. Also PR is on top of master now.

@dudekaa dudekaa force-pushed the fix-issue-107 branch 2 times, most recently from 1ea6754 to 058baee Compare July 14, 2022 10:41
@dudekaa
Copy link
Contributor Author

dudekaa commented Jul 14, 2022

Just noticed new tests, added one. And also added few more chars that needs escaping and come across my mind (<, > and & )

@leonardoanalista
Copy link
Member

thank you. Please merge it when you have a chance.

@dudekaa
Copy link
Contributor Author

dudekaa commented Jul 15, 2022

looks like I don't have sufficient rights. please feel free to merge yourself.

@leonardoanalista leonardoanalista merged commit d9fd78a into leoforfree:master Jul 15, 2022
@leonardoanalista
Copy link
Member

🎉 This PR is included in version 6.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong escaping of some special characters inside commit messages
2 participants