Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Tab italics conflict with "Use Preview Tabs" setting #2

Closed
IanVS opened this issue Dec 8, 2015 · 5 comments
Closed

Tab italics conflict with "Use Preview Tabs" setting #2

IanVS opened this issue Dec 8, 2015 · 5 comments
Labels

Comments

@IanVS
Copy link

IanVS commented Dec 8, 2015

Hi, I am really liking this theme. One problem I have though is that I use the preview tabs setting from the tabs core package. This normally means that tabs open with an italicized title, until either a change is made or the file/tab is double-clicked (at which point it remains open as a non-preview tab and the text stops being italicized.

It seems that in this theme, italicized text is always used when the editor is "dirty" with unsaved changes. This means I cannot tell if a tab is in preview mode or not, which has caused some confusion. Do you think you could stick with just using the pencil icon, and not change the style of the text?

@leo leo added the bug label Dec 8, 2015
@leo
Copy link
Owner

leo commented Dec 8, 2015

It took me a few minutes to understand what this option really does, but now I got it. The reason why I've italicized the titles was because Sublime Text's configuration has that "Preview Tabs" functionality enabled by default and I wanted to reproduce that for Atom, too.

But now I understand that this functionality already exists for Atom, it's just not enabled by default. So yes, I will definitely make the italicized title look normal again! 😊

I'm happy that you like it, btw! 😋

@IanVS
Copy link
Author

IanVS commented Dec 8, 2015

Great, thanks!

@leo
Copy link
Owner

leo commented Dec 8, 2015

No problem! This change will be published with v1.0.3, by the way.

@IanVS
Copy link
Author

IanVS commented Dec 10, 2015

Much better, thanks!

@leo
Copy link
Owner

leo commented Dec 10, 2015

@IanVS 😊

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants