Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Migrate ssh dependencies to https #86

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

shiipou
Copy link
Contributor

@shiipou shiipou commented Jul 4, 2023

Description of the changes

This PR just change the dependency link to https instead of sh, that allow to not need the deploy key to get the dependencies

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

Technical highlight/advice

@shiipou shiipou self-assigned this Jul 4, 2023
@shiipou shiipou linked an issue Jul 4, 2023 that may be closed by this pull request
6 tasks
@jonas-martinez jonas-martinez merged commit 3505aac into beta Jul 4, 2023
@jonas-martinez jonas-martinez deleted the 81-task-migrate-ssh-dependencies-to-https branch July 4, 2023 09:04
@shiipou
Copy link
Contributor Author

shiipou commented Aug 21, 2023

🎉 This PR is included in version 1.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor Author

shiipou commented Aug 30, 2023

🎉 This PR is included in version 1.0.0-beta.45 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Migrate SSH dependencies to HTTPS
2 participants