Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Call listener as function #21

Open
taorepoara opened this issue Feb 20, 2024 · 0 comments
Open

[Task] Call listener as function #21

taorepoara opened this issue Feb 20, 2024 · 0 comments
Assignees
@taorepoara
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@taorepoara
Copy link
Member

What should be done

To call a listener we have to keep the route (or at least the callListener function) in the calling scope and that is not great.

This PR parses the received data to add a call method to the Listener components that can take an event object as param.

Technical recommandation
@taorepoara taorepoara added enhancement New feature or request good first issue Good for newcomers labels Feb 20, 2024
@taorepoara taorepoara added this to Lenra Feb 20, 2024
@github-project-automation github-project-automation bot moved this to 🟣 Need triage in Lenra Feb 20, 2024
@taorepoara taorepoara moved this from 🟣 Need triage to ⚪ Todo in Lenra Mar 5, 2024
@taorepoara taorepoara self-assigned this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taorepoara taorepoara

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Lenra
Status: ⚪ Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taorepoara