New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review, refactoring, cleanup #28

Open

tomcornall opened this issue Jan 5, 2018 · 1 comment

Contributor

tomcornall commented Jan 5, 2018

Notes

Functions are executed on run, linearly.
No classes.
Lot of synchronous functions - file reads, etc. that could by asynchronous.
File is large, many lines.
Config read - library to separate it out, lemonsync readConfig should just be reading from an input.
Console Read tool/library.
File tracking - use classes for abstracting the stuff happening to them (adding together, scanning them, reading, writing)
ES6!

Member

robotpony commented Jan 5, 2018

Suggestions were:

break into classes based on obvious concepts
split into one module, and one CLI wrapper (may require some events firing back to allow for screen updates)

Pitch basics to group as a learning session, so we can all discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment