Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List files that are going to be changed #16

Open
tomcornall opened this issue Nov 16, 2017 · 1 comment
Open

List files that are going to be changed #16

tomcornall opened this issue Nov 16, 2017 · 1 comment

Comments

@tomcornall
Copy link
Contributor

Potentially we could only do this when an option --list-changes or something was provided:

https://app.intercom.io/a/apps/7236196445273cea007287c0c90a2f0d598567cc/respond/inbox/208455/conversations/12840871135

@dhalarewich
Copy link
Contributor

dhalarewich commented Jan 4, 2018

I notice that even with a fresh download of a theme, when running lemonsync it always finds new files. It also does this after overwriting (local or remote) then letting it sync, closing it, then re-running lemonsync.

🍋  Connecting to your store (https://something.lemonstand.com) ... 🍋

5 new store file(s) were found.

Do you want to overwrite your local or remote files?

Type "local" to overwrite your local theme: /zest
Type "remote" to overwrite your store's theme: zest

Hit <enter> to begin watching for local changes.

🍋  >remote

🍋  Watching for changes... 🍋

^C
$ lemonsync
🍋  Connecting to your store (https://something.lemonstand.com) ... 🍋

5 new store file(s) were found.

Do you want to overwrite your local or remote files?

Type "local" to overwrite your local theme: /zest
Type "remote" to overwrite your store's theme: zest

Hit <enter> to begin watching for local changes.

🍋  >local

Overwriting local theme files...

- /zest/.gitignore
- /zest/.git
- /zest/readme.md
- /zest/resources/.DS_Store
- /zest/.DS_Store

🍋  Watching for changes... 🍋

^C
$ lemonsync
🍋  Connecting to your store (https://something.lemonstand.com) ... 🍋

5 new store file(s) were found.

No matter what I do, there's always files to be synced.

In addition to listing files that are changed, we should narrow down why this happens so often, and have better defaults for ignoring files that are unrelated to the actual theme.

Note: my config file has lots of ignore patterns:

    "lemonsync*.json",
    ".lock",
    "*.tmp",
    "___jb_tmp___",
    ".idea",
    ".DS_Store",
    ".git*",
    ".jshintrc",
    "*.md",
    "gulp-config.json",
    "gulpfile.babel.js",
    "package.json",
    "sass-lint.json",
    "node_modules",
    "src"
  ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants