New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm package should not install dependencies via bower #62

Open

realityfilter opened this issue Dec 11, 2016 · 0 comments

realityfilter commented Dec 11, 2016

I think the package.json should list angular-ckeditor dependencies as peerDependencies.
It should not install them via bower.

bower might not even available, resulting in installation errors
dependencies of angular-ckeditor are already installed via their npm packages
in some environments (docker) even with bower installed, bower refuses to install because being run as sudo

I would suggest to remove the install script from the scripts section and add a corresponding peerDependencies section.

rars mentioned this issue

Remove bower devDependencies and place as peerDependencies #64

Open

andreiho mentioned this issue

Do not install angular-ckeditor via npm formio/ngFormBuilder#238

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment