solve issue #3 of focusing a contenteditable when placeholder was cli…

…cked

CHANGELOG.md

@@ -1,4 +1,6 @@
 
+v0.1.3
+- solved issue #3 : focus problem with contenteditable and a placeholder
 
 v0.1.2
 - plan a show after setData null when active. #2

angular-ckeditor-placeholder.js

@@ -47,6 +47,23 @@
             else if(isActive()) $timeout(show);
           });
 
+          // assist focusing when using contenteditable
+          // thank you http://stackoverflow.com/q/9093424/587407
+          element.focus(function() {
+            // focus assist is needed only after a placeholder disappeared.
+            // The placeholder, if any, is already removed at this stage.
+            // We know there was one when there is no text :
+            if (element.text()) return; // no placeholder was here, no need to assist focus.
+
+            if (document.createRange && window.getSelection) {
+              var range = document.createRange();
+              range.selectNodeContents(this);
+              var sel = window.getSelection();
+              sel.removeAllRanges();
+              sel.addRange(range);
+            }
+          });
+
           // Try to display placeholder.
           $timeout(show);
         });
@@ -82,7 +99,7 @@
          */
 
         function isActive() {
-          return ckeditor.instance.container.hasClass('placeholder');
+          return ckeditor.instance.container.hasClass(className);
         }
       }
     };

bower.json

@@ -24,7 +24,7 @@
     "test"
   ],
   "devDependencies": {
-    "angular-ckeditor": "~0.3.1",
+    "angular-ckeditor": "~0.3.2",
     "angular-mocks": "~1.3.8",
     "ckeditor": "#full/4.4.2",
     "jquery": "~2.1.3"

test/angular-ckeditor-placeholder.js

@@ -95,4 +95,9 @@ describe('CKEditor placeholder directive', function () {
 
     var element = $compile('<div ckeditor contenteditable="true" placeholder="test" ng-model="content" ready="onReady()"></div>')(scope);
   });
-});
+
+  // cf. issue #3
+  // I couldn't manage to get a test on that. If someone has ideas...
+  it.skip('should not hinder focusing in contenteditable mode');
+
+});