Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry.links #320

Open
lemon24 opened this issue Sep 5, 2023 · 0 comments
Open

Entry.links #320

lemon24 opened this issue Sep 5, 2023 · 0 comments
Labels
core enhancement help wanted

Comments

@lemon24
Copy link
Owner

lemon24 commented Sep 5, 2023 •
edited
Loading

We should expose Entry.links (Atom, feedparser), so it can be extended by plugins like reader._plugins.share.

Some thoughts:

  • Enclosures are a kind of link (at least for Atom). Should Entry.enclosures become a property? What about the reader.enclosure_dedupe plugin that updates .enclosures? Would this be a backwards-compatible change?
  • Entry.link should likely be a property returning the link with rel=alternate. Is this what feedparser is doing, or is there additional logic?
  • What should the rel of custom link types like the ones coming from the share plugin be? Atom says rel can be any fully qualified URI. (Would reader:share/twitter work?)
  • Idem for enclosure tags (although alternate is probably OK here).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lemon24