Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anticipate RefreshToken #138

Closed
fcioffi opened this issue Jul 10, 2017 · 5 comments
Closed

Anticipate RefreshToken #138

fcioffi opened this issue Jul 10, 2017 · 5 comments

Comments

@fcioffi
Copy link

fcioffi commented Jul 10, 2017

Is possibile to anticipate the token expiration so when I call token.expired() it returns true some minutes before expiration?

Thanks,
Francesco

@jonathansamines
Copy link
Collaborator

I think that is not possible right now, but seems like a use case for #132 even though that approach has its own drawbacks as described in the PR. Is that what you meant?

@fcioffi
Copy link
Author

fcioffi commented Jul 11, 2017

Hi jonathansamines.

Yes! It's the use case!

@jonathansamines
Copy link
Collaborator

@fcioffi as you can see, we are not implement the buffer functionality. However the readme was updated to reflect the use-case it's drawbacks and a possible solution.

Hope that helps!

@fcioffi
Copy link
Author

fcioffi commented Jul 28, 2017

Hi @jonathansamines, thanks for your info.

But I don't understand how do you suggest to resolve the issue? Where the README was updated?

I understand that you would like to resolve the issue not at library level but an optional parameter on function token.expired() for a subtraction?

Thanks,
FC

@jonathansamines
Copy link
Collaborator

Hi @fcioffi the readme was updated at Access token section. The reason why we are not willing to resolve this at the library, is because of the drawbacks described at #132, being the main reason the arbitrariety of the time that could be used as buffer expiration value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants