-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big ranges update #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to kotlin
Fixes contains type errors. IntRange should support contains(num) while IntProgression only support contains(int)
# Conflicts: # lib/src/range.dart
# Conflicts: # lib/src/comparable.dart # lib/src/num.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drastically improves the handling of ranges (
1.rangeTo(10)
) and expands support fromint
ranges to other types. Now ranges betweenint
,double
andComparable
(i.e.DateTime
orString
) are possible.This PR builds upon work in #45
Progressions
Further I made a distinction between ranges and progressions.
Range
A Range (
ComparableRange
,IntRange
,DoubleRange
) describes two values (start
andendInclusive
) which allows checking if a third value is within that range (Range.contains(other)
).Progression
A
Progression
is a range which allows iterating over its values (Iterable
). AnIntRange
extendsIntProgression
and allows iterating over the values with astepSize
(default1
).When a
Range
doesn't extendProgression
it's not possible to iterate over the values.Difference to Kotlins ranges
The major difference between ranges in Kotlin and dartx is that our progression don't require a different function when the starting value is bigger than the end value.
This also has consequences on the
isEmpty
property of a progression (which implementsIterable
).dartx
progressions are never empty, they always contain the start and end value (which might be the same).API changes
IntRange
int.rangeTo(int end): IntRange
(unchanged)IntProgression
(new)isEmpty
now always returnsfalse
toList()
returns a list containing at least start and end value.New:
DoubleRange
double.rangeTo(double end): DoubleRange
New:
ComparableRange<T>
Comparable<T>.rangeTo(Comparable<T> end): ComparableRange
Commonly used for
DateTime
andString
Convenience extensions:
Reverse to
Range.contains
on can ask the value if it is between two values or within a Range.between
num.between(num first, num endInclusive): bool
Comparable<T>.between(T first, T endInclusive): bool
inRange
Comparable<T>.inRange(ComparableRange<T> range): bool
num.inRange(Range<num> range): bool
Code samples