Added .asStreamAwaited() function for iterables of futures #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passsy
reviewed
Feb 5, 2020
passsy
reviewed
Feb 5, 2020
passsy
reviewed
Feb 5, 2020
|
I am trying to improve the test, but there is something really weird going on... I tried many different ways to test it but none of them are working.
Definetly there is some kind of bug on the testing library. There is something else I can do to improve that? |
|
I DID IT! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last request did not contained a case for Iterables of Futures.
I am adding it now with the name .asStreamAwaited() wich is a shortcut for calling
Stream.fromFutures.It's different from the latest one beacause this one awaits for the future completions and emits them in the order of completion.