(Wrong)[WIP] Refactoring for Exercise Submissions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion if the result object is an string + Update README on possible used traits
…annot be displayed (e.g. in Chrome)
Implementation of the Refinery
…eeds a concrete object instead just class name. Accourid to input validation paper.
Fix restrict method does not longer exists. Use applyTo instead of re…
Co-Authored-By: legionth <[email protected]>
…rainViolationException
[Fix 25368] Fix copy ilobjects
* trunk: missing ProviderFactory in tests [POC] GlobalScreen Tools dcl: refactored access class 0023917: Calendar Selection: Privat, Public Calendar, Persönliche Buchungen, Pers. Sprechstundentermine => Back in the breadcrumb move blog blocks to sec. panels Updated README for composer. remove composer-vendor-directory
* feature/6-0/plr-integration-tools: last adjustments to the GS POC moved Tools-Provider for Staff Kontext-sensitive Slates
…g else than performance)
…eriods [Fix 21716] Month Schedule gets proper period
replaced jquery nestable library with nestable2
…approved for nestable2
Correctly lock calls to removeIntermediateSolution.
Initialize $objectives as array().
…m test player does come around this
This reverts commit 0d7904e.
…_zipfolders [Fix 22296] Fix calendar dates for booking pool reservations
xus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation of this PR is to provide some refactoring and tests for the exercise submissions. This PR can be the basis of further refactorings.
Move all persistence to the repository class (ilExSubmission -> ilExcSubmissionRepository)
Fetching data from persistence has to be done in the repository class methods.
Remove TODO comments.
Can we keep 2 DB tables in the same repository?
Rename repository methods to something more specific.
Instantiate the repository in submission's contructor.
Figure out how to get rid of "getTableUserWhere" method.
PhpUnit tests